FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.2.0

Threshold is Low

Effort is Default

Summary

Classes Bugs Errors Missing Classes
155 32 0 0

Files

Class Bugs
org.indi.server.Acceptor 1
org.indi.server.Base64 16
org.indi.server.Base64$InputStream 1
org.indi.server.Base64$OutputStream 1
org.indi.server.ClientHandler 6
org.indi.server.Dispatcher 1
org.indi.server.ExternalDevice 1
org.indi.server.IndiServer 1
org.indi.server.IndiServer$1 1
org.indi.server.SaxHandler 3

org.indi.server.Acceptor

Bug Category Details Line
Unchecked/unconfirmed cast from org.indi.reactor.EventHandler to org.indi.server.ClientHandler in org.indi.server.Acceptor.onAccepted(EventHandler) STYLE BC_UNCONFIRMED_CAST 80

org.indi.server.Base64

Bug Category Details Line
org.indi.server.Base64.decode(String, int) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 1033
org.indi.server.Base64.decodeFileToFile(String, String) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 1322
org.indi.server.Base64.decodeFromFile(String) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 1211
org.indi.server.Base64.decodeToFile(String, String) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 1156
org.indi.server.Base64.decodeToObject(String) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 1085
org.indi.server.Base64.encodeBytes(byte[], int, int, int) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 742
org.indi.server.Base64.encodeFileToFile(String, String) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 1294
org.indi.server.Base64.encodeFromFile(String) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 1264
org.indi.server.Base64.encodeObject(Serializable, int) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 599
org.indi.server.Base64.encodeToFile(byte[], String) might ignore java.lang.Exception BAD_PRACTICE DE_MIGHT_IGNORE 1123
Dead store to dontBreakLines in org.indi.server.Base64.encodeObject(Serializable, int) STYLE DLS_DEAD_LOCAL_STORE 574
Dead store to buffer in org.indi.server.Base64.decodeFromFile(String) STYLE DLS_DEAD_LOCAL_STORE 1178
Null pointer dereference of bis in org.indi.server.Base64.decodeFromFile(String) CORRECTNESS NP_ALWAYS_NULL 1210
Should org.indi.server.Base64.decode(byte[], int, int, int) return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 956
Should org.indi.server.Base64.decodeFromFile(String) return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 1187
Exception is caught when Exception is not thrown in org.indi.server.Base64.decode4to3(byte[], int, byte[], int, int) STYLE REC_CATCH_EXCEPTION 890

org.indi.server.Base64$InputStream

Bug Category Details Line
Unread field: org.indi.server.Base64$InputStream.alphabet PERFORMANCE URF_UNREAD_FIELD 1402

org.indi.server.Base64$OutputStream

Bug Category Details Line
Unread field: org.indi.server.Base64$OutputStream.alphabet PERFORMANCE URF_UNREAD_FIELD 1636

org.indi.server.ClientHandler

Bug Category Details Line
Method org.indi.server.ClientHandler.getEnabled(boolean, BlobEnable) uses the same code for two switch clauses STYLE DB_DUPLICATE_SWITCH_CLAUSES 252
Method org.indi.server.ClientHandler.getEnabled(boolean, BlobEnable) uses the same code for two switch clauses STYLE DB_DUPLICATE_SWITCH_CLAUSES 263
Comparison of String objects using == or != in org.indi.server.ClientHandler.send(Object, TransferType, String) BAD_PRACTICE ES_COMPARING_STRINGS_WITH_EQ 326
Inconsistent synchronization of org.indi.server.ClientHandler.allDevices; locked 50% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 202
Inconsistent synchronization of org.indi.server.ClientHandler.device; locked 66% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 204
Potentially dangerous use of non-short-circuit logic in org.indi.server.ClientHandler.send(Object, TransferType, String) CORRECTNESS NS_DANGEROUS_NON_SHORT_CIRCUIT 326

org.indi.server.Dispatcher

Bug Category Details Line
Exception is caught when Exception is not thrown in org.indi.server.Dispatcher.deepCopy(Object) STYLE REC_CATCH_EXCEPTION 76

org.indi.server.ExternalDevice

Bug Category Details Line
org.indi.server.ExternalDevice.ExternalDevice(IndiServer, String) invokes java.lang.Thread.start() MT_CORRECTNESS SC_START_IN_CTOR 82

org.indi.server.IndiServer

Bug Category Details Line
Exception is caught when Exception is not thrown in org.indi.server.IndiServer.startAtLeastOneDevice(ArrayList) STYLE REC_CATCH_EXCEPTION 286

org.indi.server.IndiServer$1

Bug Category Details Line
The class org.indi.server.IndiServer$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON Not available

org.indi.server.SaxHandler

Bug Category Details Line
Dead store to out in org.indi.server.SaxHandler.normalize(String) STYLE DLS_DEAD_LOCAL_STORE 289
org.indi.server.SaxHandler.normalize(String) invokes inefficient new String() constructor PERFORMANCE DM_STRING_VOID_CTOR 289
org.indi.server.SaxHandler.startElement(String, String, String, Attributes) invokes inefficient new String() constructor PERFORMANCE DM_STRING_VOID_CTOR 146